Re: [HACKERS] pgbench regression test failure - Mailing list pgsql-hackers

From Steve Singer
Subject Re: [HACKERS] pgbench regression test failure
Date
Msg-id alpine.DEB.2.11.1711142200180.29536@opti.atlantida
Whole thread Raw
In response to Re: [HACKERS] pgbench regression test failure  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: [HACKERS] pgbench regression test failure  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
On Mon, 13 Nov 2017, Fabien COELHO wrote:

>
> Hello Steve,
>
>>                printf("number of transactions actually processed: " 
>> INT64_FORMAT "/%d\n",
>> -                          total->cnt - total->skipped, nxacts * nclients);
>> +                          total->cnt, nxacts * nclients);
>> 
>> I think you want ntx instead of total->cnt here.
>
> Indeed... and this is also what my git branch contains... I just sent the 
> wrong version, sorry:-( The same fix is also needed in the else branch.
>
> Here is the hopefully right version, which passes tests here.

This version seems fine.

I think it is ready for a committer


>
> -- 
> Fabien.



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [Sender Address Forgery]Re: [HACKERS] path toward fasterpartition pruning
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.