Re: BUG #13442: ISBN doesn't always roundtrip with text - Mailing list pgsql-bugs

From Fabien COELHO
Subject Re: BUG #13442: ISBN doesn't always roundtrip with text
Date
Msg-id alpine.DEB.2.10.1507280946400.3538@sto
Whole thread Raw
In response to Re: BUG #13442: ISBN doesn't always roundtrip with text  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #13442: ISBN doesn't always roundtrip with text
List pgsql-bugs
> AFAICS, that isn't exactly an improvement.  You're telling the user
> "if you have an ISBN column, you're screwed, and we are going to make it
> as painful as it can possibly be to get out of that situation".
>
> I think we'd be better off trying to migrate to a situation where these
> type names all still exist but they all act like ISBN13.  I'm not sure
> what the stages on that journey are.

Hmm... This is more or less what the previous version was doing, including
display bugs.

So the attached v3:
  - distinguishes internally between ISBN & ISBN13 (so it is clean),
    but accepts values of one for the other transparently.
  - displays ISBN as ISBN if possible, otherwise they are show as
    ISBN13. This fixes the reported bug, and the application would
    have to adapt.
  - adds regression tests, including expected errors.

The good news is that there is no extension version update, it is just a
behavioral change when ISBN13 numbers are used with the ISBN type.

--
Fabien.

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)
Next
From: dmitri.bourlatchkov@software.dell.com
Date:
Subject: BUG #13522: libtermcap.so: broken symbolic link to libncurses.so in PostgreSQL 9.4.4 binary distribution archive