Re: BUG #13442: ISBN doesn't always roundtrip with text - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #13442: ISBN doesn't always roundtrip with text
Date
Msg-id 17091.1438033021@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #13442: ISBN doesn't always roundtrip with text  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: BUG #13442: ISBN doesn't always roundtrip with text  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-bugs
Fabien COELHO <coelho@cri.ensmp.fr> writes:
> The usual exit strategy is:
>    DROP TYPE isbn CASCADE;
> Which works fine... but as a side effect silently remove ISBN columns that
> may exist in user table. I do not think it is a good idea for an extension
> update script to do that to a librarian:-)

Certainly.

> Bar any idea around this issue, I think that an extension upgrade script
> is really unadvisable, and the user should do a dump data, drop extension,
> create extension, restore data.

AFAICS, that isn't exactly an improvement.  You're telling the user
"if you have an ISBN column, you're screwed, and we are going to make it
as painful as it can possibly be to get out of that situation".

I think we'd be better off trying to migrate to a situation where these
type names all still exist but they all act like ISBN13.  I'm not sure
what the stages on that journey are.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: BUG #13442: ISBN doesn't always roundtrip with text
Next
From: Michael Paquier
Date:
Subject: Re: Memory leak in XLOG reader facility when decoding records (caused by WAL refactoring)