Re: Rounding to even for numeric data type - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Rounding to even for numeric data type
Date
Msg-id alpine.DEB.2.10.1505020842040.8161@sto
Whole thread Raw
In response to Re: Rounding to even for numeric data type  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Rounding to even for numeric data type  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
> So, attached is a patch that does 1) and 2) to make clear to the user
> how numeric and double precision behave regarding rounding. I am
> adding it to CF 2015-06 to keep track of it...

Quick review: patches applies, make check is fine, all is well.

Two minor suggestions:

All the casting tests could be put in "numeric.sql", as there are all 
related to numeric and that would avoid duplicating the values lists.

For the documentation, I would also add 3.5 so that rounding to even is 
even clearer:-)

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Kohei KaiGai
Date:
Subject: Re: feature freeze and beta schedule
Next
From: Fabien COELHO
Date:
Subject: Re: PATCH: pgbench - merging transaction logs