Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date
Msg-id akMBSHLlmeeuzK1a@paquier.xyz
Whole thread
Responses Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
List pgsql-hackers
On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote:
> Isn't mentioning pg_settings confusing instead of helpful during a
> server restart? With a reload it can help, but when the server can't
> start, hinting that the user should query pg_settings doesn't seem
> that useful.

Yeah, it is.  I don't see a reason why we should be specific about the
location where these parameters are set.  One has been setting up
recovery parameters in the GUC machine, so they most likely know where
these strings are.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: statatt_build_stavalues->LOCAL_FCINFO wrong number
Next
From: "David G. Johnston"
Date:
Subject: Re: PostgreSQL select-only CTE removal is too aggressive?