Re: statatt_build_stavalues->LOCAL_FCINFO wrong number - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: statatt_build_stavalues->LOCAL_FCINFO wrong number
Date
Msg-id akMAjiKYaEgl6_Me@paquier.xyz
Whole thread
Responses Re: statatt_build_stavalues->LOCAL_FCINFO wrong number
List pgsql-hackers
On Mon, Jun 29, 2026 at 07:13:07PM +0800, jian he wrote:
> "elemtypid" does not appear within the function (mentioned above), so
> "elemtypid" comment is wrong?

Nice catch.  These comments missed a refresh when this code has been
reworked.  I have bundled that in the patch, while on it.

> The general idea is to add a trailing comma to the last field of each enum.
> We need to add a comma after the last field in enum attribute_stats_argnum,
> clear_attribute_stats_argnum, and extended_stats_exprs_element.

I didn't see a strong need in this one, though..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kenichiro Tanaka
Date:
Subject: Re: Can we use Statistics Import and Export feature to perforamance testing?
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks