Request a Demo
Home   >   mailing lists

Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks - Mailing list pgsql-hackers

From JoongHyuk Shin
Subject Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date
Msg-id CACSdjfM9JMFfr0H+fYor5Y7Hkxh8_Ap6_5y=8B9ZoVaOh1CFKQ@mail.gmail.com
Whole thread
In response to Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
List pgsql-hackers
Tree view
On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote:
> Isn't mentioning pg_settings confusing instead of helpful during a
> server restart? With a reload it can help, but when the server can't
> start, hinting that the user should query pg_settings doesn't seem
> that useful.

You're right, and I had missed this.  Thanks.

I would rather drop the errhint from this patch entirely than fold it into the errdetail.
Any objections?

--
JH Shin

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: ci: namespace ccache by PostgreSQL major version
Next
From: Peter Smith
Date:
Subject: Re: Support EXCEPT for TABLES IN SCHEMA publications