Fix error message for MERGE foreign tables - Mailing list pgsql-hackers

From bt22nakamorit
Subject Fix error message for MERGE foreign tables
Date
Msg-id af88be42757c90e163fc4e27a2e29e0e@oss.nttdata.com
Whole thread Raw
Responses Re: Fix error message for MERGE foreign tables  (Richard Guo <guofenglinux@gmail.com>)
List pgsql-hackers
Hi,

MERGE command does not accept foreign tables as targets.
When a foreign table is specified as a target, it shows error messages 
like this:

-- ERROR:  cannot execute MERGE on relation "child1"
-- DETAIL:  This operation is not supported for foreign tables.

However, when a partitioned table includes foreign tables as partitions 
and MERGE is executed on the partitioned table, following error message 
shows.

-- ERROR:  unexpected operation: 5

The latter error message is unclear, and should be the same as the 
former one.
The attached patch adds the code to display error the former error 
messages in the latter case.
Any thoughts?

Best,
Tatsuhiro Nakamori
Attachment

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: [meson] add missing pg_attribute_aligned for MSVC in meson build
Next
From: Tom Lane
Date:
Subject: Re: GUC values - recommended way to declare the C variables?