On 2021/07/29 2:23, Fujii Masao wrote:
>
>
> On 2021/07/28 16:15, Yugo NAGATA wrote:
>>> I found another disconnect_all().
>>>
>>> /* XXX should this be connection time? */
>>> disconnect_all(state, nclients);
>>>
>>> The measurement is also not necessary here.
>>> So the above comment should be removed or updated?
>>
>> I think this disconnect_all will be a no-op because all connections should
>> be already closed in threadRun(), but I left it just to be sure that
>> connections are all cleaned-up. I updated the comment for explaining above.
>>
>> I attached the updated patch. Could you please look at this?
>
> Thanks for updating the patch! LGTM.
This patch needs to be back-patched because it fixes the bug
in measurement of disconnection delays. Thought?
But the patch fails to be back-patched to v13 or before because
pgbench's time logic was changed by commit 547f04e734.
Do you have the patches that can be back-patched to v13 or before?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
