Re: test: avoid redundant standby catchup in 049_wait_for_lsn - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: test: avoid redundant standby catchup in 049_wait_for_lsn
Date
Msg-id aeKqac6dHfCNoNxb@paquier.xyz
Whole thread
In response to test: avoid redundant standby catchup in 049_wait_for_lsn  (Xuneng Zhou <xunengzhou@gmail.com>)
Responses Re: test: avoid redundant standby catchup in 049_wait_for_lsn
Re: test: avoid redundant standby catchup in 049_wait_for_lsn
List pgsql-hackers
On Fri, Apr 17, 2026 at 08:25:35PM +0800, Xuneng Zhou wrote:
> The change preserves the same coverage while removing one redundant
> replay catch-up on the delayed standby. It appears to reduce the test
> runtime by about 7 seconds, though I have looked into why much of the
> improvement comes from this change alone.

Alexander may think differently and remove that, but I disagree.  The
test is clearly written so as we want two wait checks to happen, for
for CREATE FUNCTION, and one for CREATE PROCEDURE.  Removing the first
check to keep only the second one removes its meaning.  In short, I
see nothing wrong to deal with here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Heads Up: cirrus-ci is shutting down June 1st
Next
From: Tom Lane
Date:
Subject: Re: Heads Up: cirrus-ci is shutting down June 1st