Re: TAP tests aren't using the magic words for Windows file access - Mailing list pgsql-hackers
| From | Andrew Dunstan |
|---|---|
| Subject | Re: TAP tests aren't using the magic words for Windows file access |
| Date | |
| Msg-id | ad8a9cd6-573a-5c9d-5094-e2f53107657b@dunslane.net Whole thread Raw |
| In response to | Re: TAP tests aren't using the magic words for Windows file access (r.zharkov@postgrespro.ru) |
| Responses |
Re: TAP tests aren't using the magic words for Windows file access
|
| List | pgsql-hackers |
On 12/15/20 12:05 AM, r.zharkov@postgrespro.ru wrote: > Hello hackers, > > Are there any plans to backport the patch to earlier versions > of the Postgres? > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=114541d58e5970e51b78b77b65de16210beaab43 > > > We rarely see the issue with the pg_ctl/004_logrotate test on > the REL_12_STABLE branch. On my notebook I can easily reproduce > the "Permission denied at src/test/perl/TestLib.pm line 259" > error with the small change below. But the same test on the > 13th version and the 12th version with the TestLib patch does > not fail. > > diff --git a/src/bin/pg_ctl/t/004_logrotate.pl > b/src/bin/pg_ctl/t/004_logrotate.pl > > index bc39abd23e4..e49e159bc84 > 100644 > > --- > a/src/bin/pg_ctl/t/004_logrotate.pl > > +++ > b/src/bin/pg_ctl/t/004_logrotate.pl > > @@ -72,7 +72,7 @@ for (my > $attempts = 0; $attempts < $max_attempts; > $attempts++) > > > { > > > $new_current_logfiles = slurp_file($node->data_dir . > '/current_logfiles'); > last > if $new_current_logfiles ne > $current_logfiles; > > - > usleep(100_000); > > > + > usleep(1); > > > } > > > > > > note "now current_logfiles = $new_current_logfiles"; > > > Oops, looks like that slipped off my radar somehow, I'll see about backpatching it right away. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
pgsql-hackers by date: