On 26.08.24 07:54, Thomas Munro wrote:
> On Sat, Aug 24, 2024 at 12:28 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> In terms of $subject, this patch seems sufficient for now.
>
> WFM. I noticed you don't have an EINTR retry loop, but the man page
> doesn't say you need one, so overall this patch LGTM.
>
> + * posix_fadvise() is the simplest standardized interface that accomplishes
> + * this. We could add an implementation using libaio in the future; but note
> + * that this API is inappropriate for libaio, which wants to have a buffer
> + * provided to read into.
>
> I would consider just dropping that comment about libaio, if touching
> this paragraph. Proposals exist for AIO of course, but not with
> libaio, and better predictions with useful discussion of the topic
> seem unlikely to fit in this margin.
committed with that change
