Re: [COMMITTERS] pgsql: Fix accounting of memory needed for mergeheap. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: [COMMITTERS] pgsql: Fix accounting of memory needed for mergeheap.
Date
Msg-id ac52c586-711a-b171-d107-447dec6cace8@iki.fi
Whole thread Raw
In response to Re: pgsql: Fix accounting of memory needed for merge heap.  (Peter Geoghegan <pg@heroku.com>)
Responses Re: [COMMITTERS] pgsql: Fix accounting of memory needed for merge heap.  (Peter Geoghegan <pg@heroku.com>)
List pgsql-committers
On 12/08/2016 10:49 PM, Peter Geoghegan wrote:
> On Thu, Dec 8, 2016 at 12:20 AM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
>> While we're at it, add a safeguard for the case that we are already over
>> the limit when allocating the read buffers. That shouldn't happen, but
>> better safe than sorry.
>
> I think you should 's/Min/Max/' where the new limit is applied. Also
> suggest that the subsequent USEMEM() call have
> "state->read_buffer_size * numInputTapes" as its argument, rather than
> state->availMem, just to be neat.

D'oh, you're right, of course. Fixed, thanks for the vigilance!

- Heikki



pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: [COMMITTERS] pgsql: Fix thinko in safeguard for negative availMem.
Next
From: Peter Geoghegan
Date:
Subject: Re: [COMMITTERS] pgsql: Fix accounting of memory needed for merge heap.