Re: More issues with expressions always false (no patch) - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: More issues with expressions always false (no patch)
Date
Msg-id ab3ba51e-65bc-fdd7-b15c-e0ed6579e893@proxel.se
Whole thread Raw
In response to Re: More issues with expressions always false (no patch)  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: More issues with expressions always false (no patch)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 12/20/19 1:54 AM, Andreas Karlsson wrote:
> On 12/20/19 1:01 AM, Ranier Vilela wrote:> First case:
>> Third case:
>> \ src \ backend \ utils \ cache \ relcache.c (line 5190)
>> if (relation-> rd_pubactions)
>>
>> It will never be executed, because if relation-> rd_pubactions is 
>> true, the function returns on line 5154.
> 
> I have not looked into this one in detail, but the free at line 5192 
> looks like potentially dead code.

I have looked at it now and it seems like this code has been dead since 
the function was originally implemented in 665d1fad99e.

Peter, what do you think?

Andreas

Attachment

pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: MarkBufferDirtyHint() and LSN update
Next
From: Robert Haas
Date:
Subject: Re: backup manifests