Re: [PATCH] Add min() and max() aggregate functions for xid8 - Mailing list pgsql-hackers

> +    PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) >
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
> 
> Shouldn't we use FullTransactionIdFollows() to compare those two fxid
> values here, instead?
> 
> +    PG_RETURN_FULLTRANSACTIONID((U64FromFullTransactionId(fxid1) <
> U64FromFullTransactionId(fxid2)) ? fxid1 : fxid2);
> 
> Shouldn't we use FullTransactionIdPrecedes() to compare those two fxid
> values here, instead?
> 
> Could you add the regression tests for those min() and max() functions 
> for xid8?

Thank you for the comments.
I sent my old version of patch by mistake.
This is the updated one.

Best wishes

-- 
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION