Re: Special-case executor expression steps for common combinations - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: Special-case executor expression steps for common combinations
Date
Msg-id aa4b1339-b136-4b0c-8ddd-5ebe5ddfd88c@proxel.se
Whole thread Raw
In response to Re: Special-case executor expression steps for common combinations  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Special-case executor expression steps for common combinations
List pgsql-hackers
On 7/4/24 6:26 PM, Daniel Gustafsson wrote:
>> 2) We could generate functions which return void rather than NULL and therefore not have to do a return at all but I
amnot sure that small optimization and extra clarity would be worth the hassle. The current approach with adding
Assert()is ok with me. Daniel, what do you think?
 
> 
> I'm not sure that would move the needle enough to warrant the extra complexity.
> It could be worth pursuing, but it can be done separately from this.

Agreed.

I looked some more at the patch and have a suggestion for code style. 
Attaching the diff. Do with them what you wish, for me they make to code 
easier to read.

Andreas

Attachment

pgsql-hackers by date:

Previous
From: "Andrey M. Borodin"
Date:
Subject: Re: WIP: parallel GiST index builds
Next
From: Tomas Vondra
Date:
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations