Request a Demo
Home   >   mailing lists

Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Date
Msg-id aYIViZ-zoeH3OIy-@nathan
Whole thread Raw
In response to Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
List pgsql-hackers
Tree view 
On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
> I think we should reject this as useless code churn.  The parameter
> was needed in the past and might be needed again in the future.
> It's fairly common for other AtEOXact functions to take an isCommit
> flag, so I don't find it surprising for these to have one.

+1

-- 
nathan

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Pasword expiration warning
Next
From: Lukas Fittl
Date:
Subject: Re: Non-deterministic buffer counts reported in execution with EXPLAIN ANALYZE BUFFERS