Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Date
Msg-id aYKU4AHnabERcy1j@paquier.xyz
Whole thread Raw
In response to Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
List pgsql-hackers
On Tue, Feb 03, 2026 at 09:34:33AM -0600, Nathan Bossart wrote:
> On Tue, Feb 03, 2026 at 09:45:49AM -0500, Tom Lane wrote:
>> I think we should reject this as useless code churn.  The parameter
>> was needed in the past and might be needed again in the future.
>> It's fairly common for other AtEOXact functions to take an isCommit
>> flag, so I don't find it surprising for these to have one.
>
> +1

+1.  Symmetry is usually relevant in the signature of these cleanup
functions.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Use allocation macros in the logical replication code
Next
From: Masahiko Sawada
Date:
Subject: Re: pg_upgrade: optimize replication slot caught-up check