Request a Demo
Home   >   mailing lists

Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
Date
Msg-id 1226920.1770129949@sss.pgh.pa.us
Whole thread Raw
In response to Remove unused isCommit parameter from AtEOXact_LocalBuffers  ("zengman" <zengman@halodbtech.com>)
Responses Re: Remove unused isCommit parameter from AtEOXact_LocalBuffers
List pgsql-hackers
Tree view 
"=?ISO-8859-1?B?emVuZ21hbg==?=" <zengman@halodbtech.com> writes:
> Commit fdd13f156814f81732c188788ab1b7b14c59f4da removed the above code, but the `isCommit` parameter was left intact.

> I intend to remove this unused parameter, and also clean up the call site in `AtEOXact_Buffers` since it invokes
`AtEOXact_LocalBuffers`.

I think we should reject this as useless code churn.  The parameter
was needed in the past and might be needed again in the future.
It's fairly common for other AtEOXact functions to take an isCommit
flag, so I don't find it surprising for these to have one.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add LIMIT option to COPY FROM
Next
From: Tom Lane
Date:
Subject: Re: Get rid of the pre-C11 _Alignof define in zic.c