Re: Jonathan S. Katz
> * The fixtures edits will be purely for testing purposes; those changes will
> need to be added into the "Contributor types" section of the admin panel.
Ah ok. I can see them there, but lack permission to edit.
> * I'd note in the commit message that there are a few other cosmetic changes
> and list them out.
Ok.
> > https://www.postgresql.org/community/contributors/
What I forgot to mention is a small detail that is perhaps
interesting: I'm changing
These are the fine people that make PostgreSQL what it is today!
to
These are the fine people that made PostgreSQL what it is today!
^
Good/bad?
> > * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL
> > Contributor Profiles" sounds better than a mundane "Contributor
> > Profiles" listing
>
> This is fine; I think it's also OK to add it to the title block, since it'll
> appear in search results with that too, but I'm not wed to that opinion.
The current <title> is already "PostgreSQL: Contributor Profiles", so
duplicating that is a bit weird. (But having header title and in-page
title deviate is also weird...)
> > * I moved the "how to suggest" section to the end so the list isn't
> > cluttered with too much text at the top
>
> I'm not sure what the reasoning was to have it originally up top - maybe it
> was to make it easier to find that info, especially because the page is
> fairly long. I'd be OK with keeping it up top - it's not too much to scroll.
IIRC originally there was only some "mail webmaster" bit at the bottom.
I think that page has this information:
1. who are the people on the list
2. how do I add someone
And currently 2 is before 1, which seems weird to me at least.
> LGTM. Thanks!
Thanks!
Christoph
