Hi Christoph,
On 11/24/25 10:50 AM, Christoph Berg wrote:
> Hi,
>
> I plan to commit the attached patch to rename Contributor to
> Significant Contributor. Also included is some copy-editing of the
> pages.
Thanks! I reviewed the patch in the downstream attachment. LGTM overall,
a few notes:
* The fixtures edits will be purely for testing purposes; those changes
will need to be added into the "Contributor types" section of the admin
panel.
* I'd note in the commit message that there are a few other cosmetic
changes and list them out.
> https://www.postgresql.org/about/policies/contributors/:
>
> * really needs a "Policy" in the page title or everyone is confused
> why this page isn't listing people
This is fine.
> https://www.postgresql.org/community/contributors/
> * I added a "PostgreSQL" to the (in-page) title so "PostgreSQL
> Contributor Profiles" sounds better than a mundane "Contributor
> Profiles" listing
This is fine; I think it's also OK to add it to the title block, since
it'll appear in search results with that too, but I'm not wed to that
opinion.
> * I moved the "how to suggest" section to the end so the list isn't
> cluttered with too much text at the top
I'm not sure what the reasoning was to have it originally up top - maybe
it was to make it easier to find that info, especially because the page
is fairly long. I'd be OK with keeping it up top - it's not too much to
scroll.
> * The sections all have introductory text now (likely needs manual
> importing of the json file, like the actual "Significant" (and Past
> Significant Contributor) rename.
>
> https://www.postgresql.org/about/governance/contributors/:
>
> * add Floor (already pushed in a separate commit)
LGTM. Thanks!
Joanthan
