Re: Fix lwlock.c and wait_event_names.txt discrepancy - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix lwlock.c and wait_event_names.txt discrepancy
Date
Msg-id aHeF5LGzLRCNdkZg@paquier.xyz
Whole thread Raw
In response to Fix lwlock.c and wait_event_names.txt discrepancy  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Fix lwlock.c and wait_event_names.txt discrepancy
List pgsql-hackers
On Wed, Jul 16, 2025 at 09:30:31AM +0000, Bertrand Drouvot wrote:
> While working on [1], I noticed a discrepancy between lwlock.c and
> wait_event_names.txt for 2 wait events.

Oops.

> Indeed, the wait event names are MultixactOffsetSLRU and MultixactMemberSLRU in
> the C file but MultiXactOffsetSLRU and MultiXactMemberSLRU in the text file.
>
> That breaks joins between pg_stat_activity and pg_wait_events on the wait
> event name. PFA a patch to fix those (I'm not able to find other discrepancy
> with the "automated" work I'm doing in [1], so I'm confident there is no others).
>
> Oversight in commit 53c2a97a9266.

This is in the same line as 08b9b9e043bb, down to v17.  For
08b9b9e043bb, we were lucky enough to not be in GA, would people mind
to sneak this lwlock tranche name change in v17?  In v16 and older
versions, we have been using MultiXactOffsetSLRU (documented), not
MultixactOffsetSLRU.  So there is some history here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Log prefix missing for subscriber log messages received from publisher
Next
From: Aleksander Alekseev
Date:
Subject: Re: Missing NULL check after calling ecpg_strdup