Re: A assert failure when initdb with track_commit_timestamp=on - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: A assert failure when initdb with track_commit_timestamp=on
Date
Msg-id aGdw_ntxvklLX27a@paquier.xyz
Whole thread Raw
In response to Re: A assert failure when initdb with track_commit_timestamp=on  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
On Fri, Jul 04, 2025 at 01:26:19AM +0900, Fujii Masao wrote:
> On 2025/07/03 22:31, Andy Fan wrote:
>> I checked the fix suggested by Hayato, I think his patch is better than
>> me because his patch checks at the startup time while my patch checks at
>> each time of RecordTransactionCommit. So v3 takes his patch. v3 also
>> added the testcase suggested by Michael for test coverage, it clearly
>> proves the bug is fixed now.
>
> The patch looks good to me.

I was wondering if we should backpatch that, and decided towards a
yes here as it can be annoying.  3e51b278db6a has introduced the -c
switch in initdb in v16, but that could be reached as well if one
touches at some initialization path, perhaps in a fork.  Done, down
to v13.

Let's tackle the rest separately.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Improve error message for duplicate labels in enum types
Next
From: Michael Paquier
Date:
Subject: Re: Add pg_get_injection_points() for information of injection points