Re: Regression in statement locations - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Regression in statement locations
Date
Msg-id aCxBpHYiYWlEt5ql@paquier.xyz
Whole thread Raw
In response to Re: Regression in statement locations  (Sami Imseih <samimseih@gmail.com>)
Responses Re: Regression in statement locations
List pgsql-hackers
On Tue, May 20, 2025 at 09:58:04AM +0200, Anthonin Bonnefoy wrote:
> Looking at the tests, there are 2 additionals empty DO blocks:
> +DO $$
> +DECLARE BEGIN
> +END $$;
>
> What's the point of those? They won't be visible in the output since
> we have 'toplevel IS FALSE' in the pg_stat_statements calls and they
> don't fit the "DO block --- multiple inner queries with separators".

That's a copy-pasto.  Will remove.

> Other than that, the patch looks good.

Thanks for the review, Anthonin and Jian.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Should we optimize the `ORDER BY random() LIMIT x` case?
Next
From: Nisha Moond
Date:
Subject: Re: Logical Replication of sequences