libcurl in libpq.pc - Mailing list pgsql-hackers

From Christoph Berg
Subject libcurl in libpq.pc
Date
Msg-id aCHScGj9_dAo-gOM@msg.df7cb.de
Whole thread Raw
In response to [PATCH] Fix missing comma in Requires.private with a Make macro  (Jacob Champion <jacob.champion@enterprisedb.com>)
List pgsql-hackers
Re: Jacob Champion
> Wolfgang reported over in [1] that I've missed a comma when appending
> to the PKG_CONFIG_REQUIRES_PRIVATE list, making libpq.pc look ugly:
> 
>     Requires.private: libssl, libcrypto libcurl

Is adding libcurl there even the right move? This will make all
programs using pkgconf and linking against libpq require
Build-Depending on libcurl-dev (or more specifically,
libcurl4-openssl-dev). Alternatively, we could make libpq-dev
Depends: libcurl on libcurl-dev. Both solutions seem wrong.

Since nothing in libpq should need curl for compiling, should we drop
it there instead?

Spotted by https://ci.debian.net/packages/h/hoel/unstable/amd64/60438300/
which used PG18. (Which might have more problems as well...)

Christoph



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache
Next
From: Amit Kapila
Date:
Subject: Re: Vacuum statistics