Re: queryId constant squashing does not support prepared statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: queryId constant squashing does not support prepared statements
Date
Msg-id aB2UJSi2ZQrZ4lnY@paquier.xyz
Whole thread Raw
In response to Re: queryId constant squashing does not support prepared statements  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: queryId constant squashing does not support prepared statements
List pgsql-hackers
On Fri, May 09, 2025 at 11:05:43AM +0800, Junwang Zhao wrote:
> Why not a location and a length, it should be more natural, it
> seems we use this convention in some existing nodes, like
> RawStmt, InsertStmt etc.

These are new concepts as of Postgres 18 (aka only on HEAD), chosen
mainly to match with the internals of pg_stat_statements as far as I
recall.  Doing the same here would not hurt, but it may be better
depending on the cases to rely on a start/end.  I suspect that
switching from one to the other should not change much the internal
squashing logic.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Issues with 2PC at recovery: CLOG lookups and GlobalTransactionData
Next
From: Dmitry Dolgov
Date:
Subject: Re: queryId constant squashing does not support prepared statements