Thanks for the review.
On 2017/02/27 2:39, Robert Haas wrote:
> On Tue, Feb 21, 2017 at 7:28 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> Simon pointed out in a nearby thread [0] that the detail part of
>> partition-not-found error should show just the partition keys. I posted a
>> patch on that thread [1], but to avoid confusion being caused by multitude
>> of patches over there I'm re-posting it here.
>
> Thanks. GetPartitionFailureData seems like a strange name for a
> datatype, particularly the "Get" part. How about
> PartitionRoutingFailureInfo? Or just two out parameters.
Went with two out parameters instead of a new struct.
> Spelling: BuildSlotPartitinKeyDescription (in comment).
Fixed.
> ExecBuildSlotPartitionKeyDescription could have a comment saying that
> it's LIKE BuildIndexValueDescription() instead of copy-and-pasting the
> comments. And maybe BuildIndexValueDescription() could also get a
> comment saying that if we change anything there, we should check
> whether ExecBuildSlotPartitionKeyDescription() needs a similar change.
OK, I modified the comments. Although, I kept comments that are a bit
different.
Updated patch is attached.
Thanks,
Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
