Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pageinspect: Hash index support - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] pageinspect: Hash index support
Date
Msg-id a8e82885-6287-8c64-7b5d-19c5be8c1a6a@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] pageinspect: Hash index support  (Jesper Pedersen <jesper.pedersen@redhat.com>)
Responses Re: [HACKERS] pageinspect: Hash index support  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
Tree view 
On 1/18/17 10:45 AM, Jesper Pedersen wrote:
> Fixed in this version:
> 
> * verify_hash_page: Display magic in hex, like hash_metapage_info
> * Update header for hash_page_type
> 
> Moving the patch back to 'Needs Review'.

Please include tests in your patch.  I have posted a sample test suite
in
<https://www.postgresql.org/message-id/bcf8c21b-702e-20a7-a4b0-236ed2363d84@2ndquadrant.com>,
which you could use.

Also, as mentioned before, hash_metapage_info result fields spares and
mapp should be arrays of integer, not a text string.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: \if, \elseif, \else, \endif (was Re: [HACKERS] PSQL commands:\quit_if, \quit_unless)
Next
From: Haribabu Kommi
Date:
Subject: Re: [HACKERS] pg_hba_file_settings view patch