Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes
Date
Msg-id a87da13e-82e2-46db-ad61-8cfbd8840afd@proxel.se
Whole thread Raw
In response to Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2/11/25 9:25 PM, Tom Lane wrote:
> Greg Sabino Mullane <htamfids@gmail.com> writes:
>> I say "of course" but few people (even tech ones) know the distinction.
>> (Nor should they have to! But that's for a nearby thread). This patch aims
>> to prevent this very bad footgun by only allowing a /0 if the IP consists
>> of only zeroes. It works for ipv4 and ipv6.
> 
> More generally, should we reject if the netmask causes *any* nonzero
> IP bits to be ignored?  Our CIDR type already imposes that rule:

+1 From me too. I think we should fix the general issue rather than 
special casing /0.

Andreas




pgsql-hackers by date:

Previous
From: "Anton A. Melnikov"
Date:
Subject: Re: Change GUC hashtable to use simplehash?
Next
From: Daniel Gustafsson
Date:
Subject: Re: Assignment before assert