Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage. - Mailing list pgsql-hackers

From Gilles Darold
Subject Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.
Date
Msg-id a6eedb22-e041-a337-07ae-cea34aa4f2d3@darold.net
Whole thread Raw
In response to Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
Le 07/11/2019 à 11:52, Etsuro Fujita a écrit :
> Horiguchi-san,
>
> On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
>> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
>> contains the same mistake and needs more or less the same fix.
> Good catch!  How about rewriting "We disallow remote transactions that
> modified anything" in the comment simply to "We disallow any remote
> transactions" or something like that?  Attached is an updated patch.
> In the patch, I did s/prepare/PREPARE/ to the error message as well,
> as you proposed.
>
> Thanks again for reviewing!
>
> Best regards,
> Etsuro Fujita


Looks good for me,

-- 
Gilles Darold




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Refactor parse analysis of EXECUTE command
Next
From: Pavel Stehule
Date:
Subject: Re: Refactor parse analysis of EXECUTE command