Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Date
Msg-id CAPmGK16_SxSMX=2MLCkv62tN29XbC4rrcQKWYLtp13smweT9Jw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Gilles Darold <gilles@darold.net>)
List pgsql-hackers
Tree view 
Horiguchi-san,

On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
> contains the same mistake and needs more or less the same fix.

Good catch!  How about rewriting "We disallow remote transactions that
modified anything" in the comment simply to "We disallow any remote
transactions" or something like that?  Attached is an updated patch.
In the patch, I did s/prepare/PREPARE/ to the error message as well,
as you proposed.

Thanks again for reviewing!

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Rafia Sabih
Date:
Subject: Re: Parallel leader process info in EXPLAIN
Next
From: Tomas Vondra
Date:
Subject: Re: Using multiple extended statistics for estimates