Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message. - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Date
Msg-id CAPmGK14QV4-71Bu9LP-GJ+t41Q-_TLb_zv+q9k_=dxSMgaf_pA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Gilles Darold <gilles@darold.net>)
Responses Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
List pgsql-hackers
Hi Gilles,

On Fri, Nov 8, 2019 at 4:55 PM Gilles Darold <gilles@darold.net> wrote:
> Le 07/11/2019 à 11:52, Etsuro Fujita a écrit :
> > On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
> > <horikyota.ntt@gmail.com> wrote:
> >> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
> >> contains the same mistake and needs more or less the same fix.
> > Good catch!  How about rewriting "We disallow remote transactions that
> > modified anything" in the comment simply to "We disallow any remote
> > transactions" or something like that?  Attached is an updated patch.
> > In the patch, I did s/prepare/PREPARE/ to the error message as well,
> > as you proposed.

> Looks good for me,
>
> --
> Gilles Darold
>



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Next
From: Etsuro Fujita
Date:
Subject: Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.