Postgres Pro
Downloads
Home   >   mailing lists

Re: Take skip header out of a loop in COPY FROM - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Take skip header out of a loop in COPY FROM
Date
Msg-id a5ebb17a-320b-5b21-c159-7e796456f134@iki.fi
Whole thread Raw
In response to Re: Take skip header out of a loop in COPY FROM  (Adam Lee <ali@pivotal.io>)
Responses Re: Take skip header out of a loop in COPY FROM  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On 22/08/2019 12:54, Adam Lee wrote:
> My next thought is to call unlikely() here, but we don't have it...
> https://www.postgresql.org/message-id/CABRT9RC-AUuQL6txxsoOkLxjK1iTpyexpbizRF4Zxny1GXASGg%40mail.gmail.com

We do, actually, since commit aa3ca5e3dd in v10.

Not sure it's worth the trouble here. Optimizing COPY in general would 
be good, even small speedups there are helpful because everyone uses 
COPY, but without some evidence I don't believe particular branch is 
even measurable.

- Heikki

pgsql-hackers by date:

Previous
From: Adam Lee
Date:
Subject: Re: Take skip header out of a loop in COPY FROM
Next
From: Amit Kapila
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs