Re: pgsql: Catalog changes preparing for builtin collation provider. - Mailing list pgsql-committers

From Jeff Davis
Subject Re: pgsql: Catalog changes preparing for builtin collation provider.
Date
Msg-id a4e4e1432c1c403318774f4b0c9b25a33e44e7fa.camel@j-davis.com
Whole thread Raw
In response to Re: pgsql: Catalog changes preparing for builtin collation provider.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Catalog changes preparing for builtin collation provider.
List pgsql-committers
On Mon, 2024-03-11 at 17:08 -0400, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
>
> was perfectly correct as it stood, because pg_version is a
> PostgreSQL::Version object.  Why did you feel a need to
> editorialize on that?

The goal was to do a version check for 17 that's inclusive of
development versions.

Patch attached, following the example in AdjustUpgrade.pm. It feels a
bit inconsistent to sometimes use $oldnode->pg_version and sometimes
use $old_major_version, but it's certainly better than what I had done
in f696c0cd5f.

Regards,
    Jeff Davis


Attachment

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Update obsolete index scan TID comments.
Next
From: Jeff Davis
Date:
Subject: Re: pgsql: Catalog changes preparing for builtin collation provider.