I tried to apply the patch to master and plan to run some tests, but got
below errors due to other commits.
$ git apply --check
v7-0003-postgres-fdw-Add-support-for-parallel-abort.patch
error: patch failed: doc/src/sgml/postgres-fdw.sgml:479
error: doc/src/sgml/postgres-fdw.sgml: patch does not apply
+ * remote server in parallel at (sub)transaction end.
Here, I think the comment above could potentially apply to multiple
remote server(s).
Not sure if there is a way to avoid repeated comments? For example, the
same comment below appears in two places (line 231 and line 296).
+ /*
+ * If requested, consume whatever data is available from the socket.
+ * (Note that if all data is available, this allows
+ * pgfdw_get_cleanup_result to call PQgetResult without forcing the
+ * overhead of WaitLatchOrSocket, which would be large compared to the
+ * overhead of PQconsumeInput.)
+ */
On 2022-03-24 11:46 p.m., Etsuro Fujita wrote:
> On Thu, Mar 24, 2022 at 1:34 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>> Attached is a new patch set. The new version of 0002 is just a
>> cleanup patch (see the commit message in 0002), and I think it's
>> committable, so I'm planning to commit it, if no objections.
> Done.
>
> Attached is the 0003 patch, which is the same as the one I sent yesterday.
>
> Best regards,
> Etsuro Fujita
--
Best regards,
David
Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca
