RE: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure - Mailing list pgsql-bugs

From Floris Van Nee
Subject RE: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
Date
Msg-id a3de68e3a48c4a55a3f6f64d87486ffd@Optiver.com
Whole thread Raw
In response to Re: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure  (Michael Paquier <michael@paquier.xyz>)
Responses Re: BUG #17947: Combination of replslots pgstat issues causes error/assertion failure
List pgsql-bugs
>
> Note an extra edge case in pgstat_init_function_usage(), which should do
> the same, I guess?
>

I noticed it but wasn't sure if it was necessary here due to the exceptional case here.
It raises ereport error right after and can only reach this if the entry was created
In the call to pgstat_prep_pending_entry before it, so it seems unlikely another
backend holds a ref to it. I might be wrong though.

> Attached is an updated patch with refined comments at the top of ?
> pgstat_drop_entry(), to be applied to 15~.

Thanks for testing the patch. Updated patch looks good to me.

-Floris




pgsql-bugs by date:

Previous
From: Rahul Pandey
Date:
Subject: Re: [EXTERNAL] Re: Windows Application Issues | PostgreSQL | REF # 48475607
Next
From: Floris Van Nee
Date:
Subject: RE: error "can only drop stats once" brings down database