Re: Datetime patch - Mailing list pgsql-patches

From greg@turnstep.com
Subject Re: Datetime patch
Date
Msg-id a389ef3bb1701d92d756b567a9518202@biglumber.com
Whole thread Raw
In response to Re: Datetime patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Datetime patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Greg, does this patch still reject dates with month/days out of range?
> I see some of the range checks are removed.  Where those checks used
> only for the month/date detection?

Yes and yes. The range rejection in the previous code only allowed an
invalid date to be detected earlier than it would have otherwise. It is
the responsibility of the code following it to determine the validity of
the date we construct here.

Some very minimal checking could be put into place, but it would just be
a small subset of the full checking that occurs later on, so it seemed
better to leave all that logic in one place.


- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200307251104
-----BEGIN PGP SIGNATURE-----
Comment: http://www.turnstep.com/pgp.html

iD8DBQE/IUhQvJuQZxSWSsgRAthUAJ42qjxGOVRX/Ak/RF5z0KlZu2CUQwCfeYoy
IxRZhzqzNWJM8NeqFKLGesE=
=4rCE
-----END PGP SIGNATURE-----



pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PG Patch (fwd) [openserver patch followup #2]
Next
From: Bruce Momjian
Date:
Subject: Re: Datetime patch