Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Date
Msg-id a2d6a208-13ac-69f8-9fb7-1d68d7fb5bbd@dunslane.net
Whole thread Raw
In response to [PATCH] Honor PG_TEST_NOCLEAN for tempdirs  (Jacob Champion <jchampion@timescale.com>)
Responses Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
List pgsql-hackers


On 2023-06-26 Mo 19:55, Jacob Champion wrote:
Hello,

I was running the test_pg_dump extension suite, and I got annoyed that
I couldn't keep it from deleting its dump artifacts after a successful
run. Here's a patch to make use of PG_TEST_NOCLEAN (which currently
covers the test cluster's base directory) with the Test::Utils
tempdirs too.

(Looks like this idea was also discussed last year [1]; let me know if
I missed any more recent suggestions.)


-        CLEANUP => 1);
+        CLEANUP => not defined $ENV{'PG_TEST_NOCLEAN'});


This doesn't look quite right. If PG_TEST_CLEAN had a value of 0 we would still do the cleanup. I would probably use something like:

    CLEANUP => $ENV{'PG_TEST_NOCLEAN'} // 1

i.e. if it's not defined at all or has a value of undef, do the cleanup, otherwise use the value.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Make uselocale protection more consistent
Next
From: Andres Freund
Date:
Subject: Re: ReadRecentBuffer() doesn't scale well