Re: shared-memory based stats collector - v70 - Mailing list pgsql-hackers

From Anton A. Melnikov
Subject Re: shared-memory based stats collector - v70
Date
Msg-id a13e8cdf-b97a-4ecb-8f42-aaa367974e29@postgrespro.ru
Whole thread Raw
In response to Re: shared-memory based stats collector - v70  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
Responses Re: shared-memory based stats collector - v70
List pgsql-hackers
Hi!

Found a place in the code of this patch that is unclear to me:

https://github.com/postgres/postgres/blob/1acf10549e64c6a52ced570d712fcba1a2f5d1ec/src/backend/utils/activity/pgstat.c#L1658

Owing assert() the next if() should never be performed, but the comment above says the opposite.
Is this assert really needed here? And if so, for what?

Would be glad for clarification.


With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Memory leak in WAL sender with pgoutput (v10~)
Next
From: Alvaro Herrera
Date:
Subject: Re: [PoC] Reducing planning time when tables have many partitions