Re: [HACKERS] Adding support for Default partition in partitioning - Mailing list pgsql-hackers

From Amit Langote
Subject Re: [HACKERS] Adding support for Default partition in partitioning
Date
Msg-id a1267081-6e9a-e570-f6cf-34ff801bf503@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Adding support for Default partition in partitioning  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] Adding support for Default partition in partitioning  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
Re: [HACKERS] Adding support for Default partition in partitioning  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Re: [HACKERS] Adding support for Default partition in partitioning  (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>)
List pgsql-hackers
Oops, I meant to send one more comment.

On 2017/06/15 15:48, Amit Langote wrote:
> BTW, I noticed the following in 0002
+                     errmsg("there exists a default partition for table \"%s\", cannot
add a new partition",

This error message style seems novel to me.  I'm not sure about the best
message text here, but maybe: "cannot add new partition to table \"%s\"
with default partition"

Note that the comment applies to both DefineRelation and
ATExecAttachPartition.

Thanks,
Amit




pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Adding support for Default partition in partitioning
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()