Re: Flush pgstats file during checkpoints - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Flush pgstats file during checkpoints
Date
Msg-id Zpc1kakzlBlOZqvU@paquier.xyz
Whole thread Raw
In response to Re: Flush pgstats file during checkpoints  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Fri, Jul 12, 2024 at 12:10:26PM +0000, Bertrand Drouvot wrote:
> Looking at 0001:
>
> +               /* error logged already */
>
> Maybe mention it's already logged by durable_rename() (like it's done in
> InstallXLogFileSegment(), BaseBackup() for example).
>
> Except this nit, 0001 LGTM.

Tweaked the comment, and applied 0001 for durable_rename().  Thanks
for the review.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: feichanghong
Date:
Subject: Re: temp table on commit delete rows performance issue
Next
From: Nathan Bossart
Date:
Subject: Re: Remove dependence on integer wrapping