On Mon, Jul 08, 2024 at 11:55:28AM +0200, Joel Jacobson wrote:
> Patch didn't apply to HEAD nor on top of any of the previous commits either,
> but I couldn't figure out why based on the .rej files, strange.
> I copy/pasted the parts from the patch to test it. Let me know if you need a
> rebased version of it, in case you will need to do the same, to save some work.
Strange. I have just downloaded v2 again. `patch -p1` and `git am`
are both working here.
> Also noted the below in your last commit:
>
> a6417078c414 has introduced as project policy that new features
> committed during the development cycle should use new OIDs in the
> [8000,9999] range.
>
> 4564f1cebd43 did not respect that rule, so let's renumber pg_get_acl()
> to use an OID in the correct range.
>
> Thanks for the info!
> Will make sure to use the `src/include/catalog/renumber_oids.pl` tool
> for future patches.
No problem. This is the kind of tweaks that are really easy to
forget.
--
Michael
