Re: Allow non-superuser to cancel superuser tasks. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Allow non-superuser to cancel superuser tasks.
Date
Msg-id Zo4bDSyQTtqmotJV@paquier.xyz
Whole thread Raw
In response to Re: Allow non-superuser to cancel superuser tasks.  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: Allow non-superuser to cancel superuser tasks.
List pgsql-hackers
On Wed, Jul 10, 2024 at 10:03:04AM +0500, Kirill Reshke wrote:
> The problem is the error message has been changed.
>
> # DETAIL:  Only roles with privileges of the
> "pg_signal_autovacuum_worker" role may terminate autovacuum workers.'
> #     doesn't match '(?^:ERROR:  permission denied to terminate
> process\nDETAIL:  Only roles with privileges of the
> "pg_signal_autovacuum_worker" role may terminate autovacuum worker
> processes.)'
> # Looks like you failed 1 test of 2.
>
> I changed the test to match the error message.

The script has two tests, and the CI is failing for the second test
where we expect the signal to be processed:
[12:48:23.370] #   Failed test 'autovacuum worker signaled with
pg_signal_autovacuum_worker granted'
[12:48:23.370] #   at t/006_signal_autovacuum.pl line 90.

It is true that the first test where we expect the signal to not go
through also failed as the DETAIL string has been changed, which is
what you've fixed :)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Allow non-superuser to cancel superuser tasks.
Next
From: "David G. Johnston"
Date:
Subject: Re: array_in sub function ReadArrayDimensions error message