Postgres Pro
Downloads
Home   >   mailing lists

Re: walsender.c comment with no context is hard to understand - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: walsender.c comment with no context is hard to understand
Date
Msg-id Znz8GsfRVgYDOFb2@paquier.xyz
Whole thread Raw
In response to Re: walsender.c comment with no context is hard to understand  (vignesh C <vignesh21@gmail.com>)
Responses Re: walsender.c comment with no context is hard to understand
List pgsql-hackers
Tree view 
On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote:
> On Mon, 3 Jun 2024 at 11:21, Peter Smith <smithpb2250@gmail.com> wrote:
>> Perhaps the comment should say something like it used to:
>> /* Fail if there is not enough WAL available. This can happen during
>> shutdown. */
>
> Agree with this, +1 for this change.

That would be an improvement.  Would you like to send a patch with all
the areas you think could stand for improvements?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: libpq: Fix lots of discrepancies in PQtrace
Next
From: Peter Eisentraut
Date:
Subject: Re: thread-safety: gmtime_r(), localtime_r()