Postgres Pro
Downloads
Home   >   mailing lists

Re: walsender.c comment with no context is hard to understand - Mailing list pgsql-hackers

From Peter Smith
Subject Re: walsender.c comment with no context is hard to understand
Date
Msg-id CAHut+PtDwJY-ZKoj9CLDnpN+j_p0SmGYbrkSywD3gFdZZuL5fA@mail.gmail.com
Whole thread Raw
In response to Re: walsender.c comment with no context is hard to understand  (Michael Paquier <michael@paquier.xyz>)
Responses Re: walsender.c comment with no context is hard to understand
List pgsql-hackers
Tree view 
On Thu, Jun 27, 2024 at 3:44 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jun 26, 2024 at 02:30:26PM +0530, vignesh C wrote:
> > On Mon, 3 Jun 2024 at 11:21, Peter Smith <smithpb2250@gmail.com> wrote:
> >> Perhaps the comment should say something like it used to:
> >> /* Fail if there is not enough WAL available. This can happen during
> >> shutdown. */
> >
> > Agree with this, +1 for this change.
>
> That would be an improvement.  Would you like to send a patch with all
> the areas you think could stand for improvements?
> --

OK, I attached a patch equivalent of the suggestion in this thread.

======
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Improve EXPLAIN output for multicolumn B-Tree Index
Next
From: jian he
Date:
Subject: Re: Virtual generated columns