On Mon, Jun 10, 2024 at 02:50:33PM +0900, Michael Paquier wrote:
> On Sun, Jun 09, 2024 at 03:00:00PM +0300, Alexander Lakhin wrote:
>> 4)
>> I guess, make_tuple_indirect() could be improved with:
>> /* only work on existing, not-null varlenas */
>> if (TupleDescAttr(tupdesc, i)->attisdropped ||
>> nulls[i] ||
>> - TupleDescAttr(tupdesc, i)->attlen != -1)
>> + TupleDescAttr(tupdesc, i)->attlen != -1 ||
>> + TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
>
> Fun. True enough that this function is only here for toastable
> values, so that makes sense.
This one was indeed simple enough, so fixed it for now.
--
Michael
