Re: IPC::Run::time[r|out] vs our TAP tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: IPC::Run::time[r|out] vs our TAP tests
Date
Msg-id Zg9eAkXZUymvwvp3@paquier.xyz
Whole thread Raw
In response to Re: IPC::Run::time[r|out] vs our TAP tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: IPC::Run::time[r|out] vs our TAP tests
List pgsql-hackers
On Thu, Apr 04, 2024 at 07:09:53PM -0400, Tom Lane wrote:
> If you have time, that'd be great.  What I suspect is that that
> machine's readline isn't regurgitating the string verbatim but is
> doing something fancy with backspaces or other control characters.
> But we need to see what it's actually emitting before there's
> much hope of adjusting the expected-output regex.

I have been able to reproduce the failure manually and your patch is
providing more information, indeed, as of:
[10:21:44.017](0.002s) ok 83 - \r works
[10:24:45.462](181.445s) # pump_until: timeout expired when searching
for "(?^::\{\?VERBOSITY} )" with stream: "\echo :{?VERB^G^Mpostgres=#
\echo :\{\?VERBOSITY\} "
psql query timed out at
/home/pgbuildfarm/git/postgres/src/bin/psql/../../../src/test/perl/PostgreSQL/Test/BackgroundPsql.pm
line 281.

This stuff is actually kind of funny on this host, "\echo :{?VERB\t"
completes to something incorrect, as of:
postgres=# \echo :\{\?VERBOSITY\}

Attaching the log file, for reference.  Now I can see that this uses
libedit at 3.1-20181209, which is far from recent.  I'd be OK to just
remove libedit from the build to remove this noise, still I am
wondering if 927332b95e77 got what it was trying to achieve actually
right.  Thoughts?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?
Next
From: Michael Paquier
Date:
Subject: Re: Weird test mixup