Re: Remove unnecessary code from psql's watch command - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove unnecessary code from psql's watch command
Date
Msg-id Zeemk0eJoucp4zVx@paquier.xyz
Whole thread Raw
In response to Remove unnecessary code from psql's watch command  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: Remove unnecessary code from psql's watch command
List pgsql-hackers
On Tue, Mar 05, 2024 at 10:05:52PM +0900, Yugo NAGATA wrote:
> In the current code of do_watch(), sigsetjmp is called if WIN32
> is defined, but siglongjmp is not called in the signal handler
> in this condition. On Windows, currently, cancellation is checked
> only by cancel_pressed, and  calling sigsetjmp in do_watch() is
> unnecessary. Therefore, we can remove code around sigsetjmp in
> do_watch(). I've attached the patch for this fix.

Re-reading the top comment of sigint_interrupt_enabled, it looks like
you're right here.  As long as we check for cancel_pressed there
should be no need for any special cancellation handling here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Tristan Partin"
Date:
Subject: Re: Refactoring backend fork+exec code
Next
From: Thomas Munro
Date:
Subject: Re: pg_upgrade --copy-file-range