Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
Date
Msg-id ZeZQ1TWRWX9TKjCY@paquier.xyz
Whole thread Raw
In response to Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
List pgsql-hackers
Tree view 
On Mon, Mar 04, 2024 at 03:08:03PM -0300, Ranier Vilela wrote:
> I can't see any user validation at the function pg_newlocale_from_collation.

Matthias is right, look closer.  I can see more than one check,
especially note the one related to the collation version mismatch that
should not be silently ignored.

> meson test pass all checks.

Collations are harder to test because they depend on the environment
where the test happens, especially with ICU.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Adding deprecation notices to pgcrypto documentation
Next
From: David Rowley
Date:
Subject: Re: a wrong index choose when statistics is out of date