Re: Is this a problem in GenericXLogFinish()? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Is this a problem in GenericXLogFinish()?
Date
Msg-id ZcCWQ9uOkZkX4gGx@paquier.xyz
Whole thread Raw
In response to RE: Is this a problem in GenericXLogFinish()?  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: Is this a problem in GenericXLogFinish()?
List pgsql-hackers
On Mon, Feb 05, 2024 at 07:57:09AM +0000, Hayato Kuroda (Fujitsu) wrote:
> You are right. Based on the previous discussions, PageSetLSN() must be called
> after the MakeBufferDirty(). REGBUF_NO_CHANGE has been introduced for skipping
> these requirements. Definitevely, no_change buffers must not be PageSetLSN()'d.
> Other pages, e.g., metabuf, has already been followed the rule.

At quick glance, this v2 seems kind of right to me: you are setting
the page LSN only when the page is registered in the record and
actually dirtied.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: meson: catalog/syscache_ids.h isn't installed
Next
From: Yugo NAGATA
Date:
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row